[THRIFT-4463] PHP generated code match PSR-2

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.12.0
• Component/s: PHP - Compiler
• Assignee: Robert Lu
• Reporter: Robert Lu
• Created: 18/Jan/18 01:32
• Updated: 27/Dec/18 15:25
• Resolved: 24/Jan/18 05:13

Description

When use thrift compiler to generate PHP code, there are many issues doesn't match PSR-2

• indent by 2 spaces, PSR-2 require 4 spaces.
• Opening brace should be on a new line (for function)
• The static declaration must come after the visibility declaration
• etc.

 

So, we can make generated code more readable, match PSR-2(almost).

 

 

Issue Links

• links to: GitHub Pull Request #1473