Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4463

PHP generated code match PSR-2

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0
    • Component/s: PHP - Compiler
    • Labels:
      None

      Description

      When use thrift compiler to generate PHP code, there are many issues doesn't match PSR-2

      • indent by 2 spaces, PSR-2 require 4 spaces.
      • Opening brace should be on a new line (for function)
      • The static declaration must come after the visibility declaration
      • etc.

       

      So, we can make generated code more readable, match PSR-2(almost).

       

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Robert Lu Robert Lu
                Reporter:
                Robert Lu Robert Lu
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: