Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4421

golang tests rely on gomock, which has change behaviour, causing tests to fail

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.12.0
    • Component/s: Go - Library
    • Labels:
      None
    • Environment:

      Ubuntu 16.04.3 amd64

      Description

      Golang gomock's Controller object no longer allows multiple invocations of Finish(). But the lib/go unit-tests use this idiom. So change that (trivial).

        Attachments

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              chetmurthy Chet Murthy

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment