[THRIFT-4410] Extra ending underscore with field ending with `result` for Golang

• Type: Question
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 0.10.0
• Component/s: Go - Compiler

Environment

macos high sierra

• Assignee: Unassigned
• Reporter: Bob Cao
• Created: 06/Dec/17 04:52
• Updated: 10/Dec/17 05:29

Description

Given a struct where fields ending with result

struct Test {
    1: optional string id_result
    2: optional string name_result
    3: optional string full_description_result
    4: optional string image_url_result
}

The generated go codes are

type Test struct {
  IDResult_ *string `thrift:"id_result,1" db:"id_result" json:"id_result,omitempty"`
  NameResult_ *string `thrift:"name_result,2" db:"name_result" json:"name_result,omitempty"`
  FullDescriptionResult_ *string `thrift:"full_description_result,3" db:"full_description_result" json:"full_description_result,omitempty"`
  ImageURLResult_ *string `thrift:"image_url_result,4" db:"image_url_result" json:"image_url_result,omitempty"`
}

I am expecting the field has the same name as defined (no undersore at the end).

Thanks jensg for pointing out the codes, if anyone could en-light me about why IDL identifiers end with "Args"/"Result" interferes with the implicit service, that will be much appreciated!!

Issue Links

• is a child of: THRIFT-2009 Go redeclaration error