[THRIFT-4384] Using a concurrent client with cpp async is not safe.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.10.0, 0.11.0, 0.12.0
• Fix Version/s: 0.13.0
• Component/s: C++ - Compiler, C++ - Library
• Labels: async

Environment

Should affect all platforms but has been noticed first on Windows, x86_64.

• Flags: Important
• Assignee: James E. King III
• Reporter: Michael Eiler
• Created: 13/Nov/17 14:59
• Updated: 16/Oct/19 22:26
• Resolved: 03/Feb/19 03:10

Description

I'm using the generated *ServiceConcurrentClient classes. They should allow me to call multiple functions at the same time.

The issue as that the ::apache::thrift::async::TConcurrentClientSyncInfo class is a member of the generated service. If I have a project with multiple services sharing the same connection (protocol) with each other, the services will not be mutually excluded from reading on the same socket.

I did a small test with patching the generated code and injecting the same instance of TConcurrentClientSyncInfo into all my services and everything was fine.

Question: Do you need a small project to reproduce this or is it obvious enough? Just check out any generated code and you will see that the TConcurrentClientSyncInfo is not shared between different services.

Issue Links

• links to: GitHub Pull Request #1718