[THRIFT-4368] Guaranteed NPE in TBaseAsyncProcessor.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.13.0
• Component/s: Java - Library
• Assignee: James E. King III
• Reporter: Christian Ciach
• Created: 24/Oct/17 07:33
• Updated: 16/Oct/19 22:27
• Resolved: 04/Jan/19 19:27

Description

While creating a pull request for another ticket, the null-analyzer of Eclipse found a guaranteed NullPointerException in org.apache.thrift.TBaseAsyncProcessor<I>.

In the method process(AsyncFrameBuffer) we see this code fragment:

    AsyncProcessFunction fn = processMap.get(msg.name);
        if (fn == null) {
            TProtocolUtil.skip(in, TType.STRUCT);
            in.readMessageEnd();
            if (!fn.isOneway()) {

The variable fn can only be null in the last line.

Issue Links

• links to: GitHub Pull Request #1669