[THRIFT-4331] C++: TSSLSockets bug in handling huge messages, bug in handling polling

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: C++ - Library
• Patch Info: Patch Available
• Flags: Patch, Important
• Assignee: James E. King III
• Reporter: Martin Haimberger
• Created: 15/Sep/17 11:02
• Updated: 18/Dec/18 16:24
• Resolved: 06/Oct/17 12:23

Description

The TSSLSocket class did not handle large messages, because a underlying TCP socket may signal bytes received, while SSL_read() may not have bytes available. After maxretries (5) the function returned -1, which got interpreted as unsigned integer for read bytes.

Futher the waitForEvent methode, did only set THRIFT_POLLIN or THRIFT_POLLOUT, but it gets used where SSL needs to send AND receive bytes for some operations (like close). So in the case of write wanted, THRIFT_POLLIN is also set to cover these read/write operations.

Pullrequest for master and 0.10.0 branch will follow.

Issue Links

• is duplicated by: THRIFT-4366 upgrade thrift lib to 0.10 ,coredump at readMessageBegin
• links to: GitHub Pull Request #1362
• links to: GitHub Pull Request #1363