Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4330

Allow unused crates in Rust files

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.11.0
    • None
    • None

    Description

      Currently thrift generated .rs files include following attributes:

      #![allow(unused_imports)]
      #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, type_complexity))]
      #![cfg_attr(rustfmt, rustfmt_skip)]

      I propose to add
      #![allow(unused_extern_crates)]

      to remove warning when using Rust nightly.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            sadikovi Ivan Sadikov
            sadikovi Ivan Sadikov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment