[THRIFT-4257] Typescript async callbacks do not provide the correct types

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11.0
• Component/s: JavaScript - Compiler
• Labels: TypeScript
• Patch Info: Patch Available
• Assignee: Mike Morton
• Reporter: Mike Morton
• Created: 19/Jul/17 13:33
• Updated: 14/Dec/17 13:55
• Resolved: 30/Jul/17 10:03

Description

The aysnc callbacks provided for typescript do not provide complete information for the objects being returned. Example:

  GetOwnInfo(): UserInfo;
  GetOwnInfo(callback: Function): JQueryXHR;

Both the Function and JQueryXHR do not provide type information about UserInfo.

The proposed fix is to have it generate the following:

  GetOwnInfo(): UserInfo;
  GetOwnInfo(callback: (data: UserInfo)=>void): JQueryPromise<UserInfo>;

I have submitted a pull request here: https://github.com/apache/thrift/pull/1310

Issue Links

• links to: GitHub Pull Request #1310