Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-424

Steal ProtocolBuffers' VarInt implementation for C++

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 0.9.3
    • Component/s: C++ - Library
    • Labels:
      None

      Description

      Protocol Buffers use the same varint format as TCompactProtocol (not, as I had previously believed, TDenseProtocol, which uses the MIDI VLQ format). They have a much smarter C++ decoder than ours (and probably a better encoder also). Protocol Buffers is (are?) three-clause BSD licensed, which means that we should be able to cough borrow cough their implementation and use it for our C++ TCompactProtocol implementation.

      We might even be able to do the same for Java and Python.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dreiss David Reiss
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: