Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4193

Lower the default maxReadBufferBytes for non-blocking servers

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.11.0
    • Java - Library
    • None

    Description

      AbstractNonblockingServerArgs sets the default maximum read buffer size to Long.MAX_VALUE. Almost every machine will probably OOME before it succeeds in hitting that maximum. It should have a lower maximum, perhaps 256 MB like the maximum frame size in the cpp implementation

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            Github user roshan commented on the issue:

            https://github.com/apache/thrift/pull/1264

            It is configurable using the `maxReadBufferBytes` argument, but the default is just really high.

            githubbot ASF GitHub Bot added a comment - Github user roshan commented on the issue: https://github.com/apache/thrift/pull/1264 It is configurable using the `maxReadBufferBytes` argument, but the default is just really high.
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/thrift/pull/1264

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1264
            jensg Jens Geyer added a comment -

            Committed, thanks!

            jensg Jens Geyer added a comment - Committed, thanks!

            People

              roshangeorge Roshan George
              roshangeorge Roshan George
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: