[THRIFT-4166] Recent fix to remove boost::lexical_cast usage broke VS2010

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.11.0
• Fix Version/s: 0.11.0
• Component/s: C++ - Library

Environment

VS2010

• Assignee: James E. King III
• Reporter: James E. King III
• Created: 04/Apr/17 19:18
• Updated: 14/Dec/17 13:56
• Resolved: 06/Apr/17 12:46

Description

Removal of boost::lexical_cast and replaced with code that calls std::log10(2). std::log10(2) is ambiguous to VS2010.

1. Fix build breakage
2. add VS2010 32-bit build job to Appveyor to prevent future regression.

Issue Links

• is broken by: THRIFT-4138 Fix remaining undefined behavior invalid vptr casts in C++ library
• links to: GitHub Pull Request #1237