Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4166

Recent fix to remove boost::lexical_cast usage broke VS2010

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      VS2010

      Description

      Removal of boost::lexical_cast and replaced with code that calls std::log10(2). std::log10(2) is ambiguous to VS2010.

      1. Fix build breakage
      2. add VS2010 32-bit build job to Appveyor to prevent future regression.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                jking3 James E. King III
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: