[THRIFT-4150] Python server or cpp client do not handle an unimplemented service method gracefully

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.10.0
• Component/s: C++ - Compiler, C++ - Library, Python - Compiler, Python - Library

Environment

Ubuntu Docker

• Assignee: Unassigned
• Reporter: James E. King III
• Created: 30/Mar/17 15:49
• Updated: 30/Mar/17 15:49

Description

I added a new method to the ThriftTest service and I implemented the server and client in C+. In the C+ client I added exception handling to catch TProtocolException and std::exception. I expected that when TestClient sent in a method that the server had not implemented, a TProtocolException(NOT_IMPLEMENTED) would be returned. The server log indicates it got to this point in theory:

ERROR:root:'TestHandler' object has no attribute 'testRequired'
Traceback (most recent call last):
  File "/home/jking/thrift/github/thrift/test/py/gen-py/ThriftTest/ThriftTest.py", line 1593, in process_testRequired
    self._handler.testRequired(args.req)

However on the C++ client side, a std::exception was received and NOT a TProtocolException, which is a bug:

testClient.testRequired() =>*** FAILED *** got back std::exception Internal error