[THRIFT-4132] Generated JavaScript code is missing a undefined check

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.10.0
• Component/s: JSON - Compiler

Environment

All

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Martin Hejnfelt
• Created: 24/Mar/17 14:45
• Updated: 07/Apr/17 09:29
• Resolved: 07/Apr/17 09:29

Description

The generated code of a *_result object can take an "args" argument to its "constructor". However, at least when using WebSocket, the *_result object is not passed an "args" parameter, hence args is undefined. However the code still makes an instanceof test on args, causing an exception to be thrown at least on newer browsers (Tested on Chrome 57 and Firefox 52). Adding an "args !== undefined &&" in front of this, makes everything work nicely again.