[THRIFT-4129] C++ TNonblockingServer fd leak when failing to dispatch new connections

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.3, 0.10.0
• Fix Version/s: 0.11.0
• Component/s: C++ - Library
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 22/Mar/17 18:52
• Updated: 14/Dec/17 13:56
• Resolved: 22/Mar/17 19:11

Description

In THRIFT-2789 the error handling for connections where notify fails leaks a file descriptor.

This was reported and fixed in a pull request without an Apache Jira entry:

https://github.com/apache/thrift/pull/1210/files

When failing to dispatch new connections to other IO threads other
than the number 0, we returned these connections for reuse without
closing them, so the corresponding fds were leaked forever.

We should close these connections instead.

Issue Links

• is broken by: THRIFT-2789 TNonblockingServer leaks socket FD's under load
• links to: GitHub Pull Request #1210