Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4129

C++ TNonblockingServer fd leak when failing to dispatch new connections

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.3, 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: C++ - Library
    • Labels:
      None

      Description

      In THRIFT-2789 the error handling for connections where notify fails leaks a file descriptor.

      This was reported and fixed in a pull request without an Apache Jira entry:

      https://github.com/apache/thrift/pull/1210/files

      When failing to dispatch new connections to other IO threads other
      than the number 0, we returned these connections for reuse without
      closing them, so the corresponding fds were leaked forever.

      We should close these connections instead.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              jking3 James E. King III

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment