[THRIFT-4102] TBufferedTransport performance issue since 0.10.0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Python - Library
• Assignee: James E. King III
• Reporter: Jin Yao
• Created: 22/Feb/17 13:52
• Updated: 14/Dec/17 13:55
• Resolved: 24/Feb/17 15:29

Description

I upgrade thrift from 0.9.3 to 0.10.0, and our rpc calls slow down.
I digged around the code, and find maybe it caused by the write function in TBufferedTransport.

The last line seems useless, but cost time.

TTransport.py

def write(self, buf):
    try:
        self.__wbuf.write(buf)
        except Exception as e:
            # on exception reset wbuf so it doesn't contain a partial function call
            self.__wbuf = BufferIO()
            raise e
    self.__wbuf.getvalue() # it seems useless, but cost time

Issue Links

• depends upon: THRIFT-1857 Python 3.X Support
• links to: GitHub Pull Request #1203