Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
0.11.0
-
None
-
Appveyor CI
Description
C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj] C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note: see previous definition of 'AI_ADDRCONFIG' (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp) TPipe.cpp C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj] C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note: see previous definition of 'AI_ADDRCONFIG' (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp) C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\transport\TPipe.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
from Appveyor CI build:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/951
It looks like we need to include the correct winsock header before we determine if AI_ADDRCONFIG needs to be defined.
Attachments
Issue Links
- links to