Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4077

AI_ADDRCONFIG redefined after recent change to PlatformSocket header

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.11.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      Appveyor CI

      Description

      C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
        C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note: see previous definition of 'AI_ADDRCONFIG' (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadPoolServer.cpp)
        TPipe.cpp
      C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
        C:\projects\thrift\lib\cpp\src\thrift/transport/PlatformSocket.h(82): note: see previous definition of 'AI_ADDRCONFIG' (compiling source file C:\projects\thrift\lib\cpp\src\thrift\server\TThreadedServer.cpp)
      C:\Program Files (x86)\Windows Kits\8.1\Include\shared\ws2def.h(858): warning C4005: 'AI_ADDRCONFIG': macro redefinition (compiling source file C:\projects\thrift\lib\cpp\src\thrift\transport\TPipe.cpp) [C:\projects\thrift\cmake-build\lib\cpp\thrift_static.vcxproj]
      

      from Appveyor CI build:

      https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/951

      It looks like we need to include the correct winsock header before we determine if AI_ADDRCONFIG needs to be defined.

        Attachments

          Activity

            People

            • Assignee:
              jking3 James E. King III
              Reporter:
              jking3 James E. King III

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment