Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4074

Unnecessary suppress warnings (unused)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.10.0
    • Fix Version/s: None
    • Component/s: Java - Compiler
    • Labels:
      None

      Description

      Some generated Java files do not have unused variables. This results an a warning in some compilers (Eclipse, for one), that the warnings suppression for unused elements itself is unnecessary.

      Some unused variables appear to simply be unnecessary code generation. These should be removed.

      Others may affect serialization if changed, and are intentionally unused for backwards compatibility because they are class fields.
      If this is the case, the warnings suppression about them being unused should appear on the unused item itself when it is declared, rather than on the class as a whole.

      If these two steps are done, then there is no need to continue to suppress the unused types for all files, globally at the top of the file.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ctubbsii Christopher Tubbs
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: