[THRIFT-4065] Document Perl ForkingServer signal restriction imposed by THRIFT-3848 and remove unnecessary code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Perl - Library

Environment

Ubuntu 14.04 LTS, Perl 5.18

• Assignee: James E. King III
• Reporter: James E. King III
• Created: 02/Feb/17 18:12
• Updated: 14/Dec/17 13:55
• Resolved: 09/Feb/17 01:54

Description

The Perl ForkingServer sets SIGCHLD to be ignores so that the forks can be automatically reaped, since the ForkingServer doesn't care about the child exit code.
The fix for THRIFT-3848 was incomplete. It needs to reset the signal handler in the child to use a default SIGCHLD handler so any thrift handler implementation relying on SIGCHLD will execute properly.

Also due to the fact that SIGCHLD is ignored in ForkingServer, the _collectChildren and call to waitpid() are unnecessary and can be removed, along with the children hash, from _parent().

Issue Links

• is broken by: THRIFT-3848 As an implementer of a perl socket server, I do not want to have to remember to ignore SIGCHLD for it to work properly
• links to: GitHub Pull Request #1176