[THRIFT-4026] TSSLSocket doesn't work with Python < 2.7.9

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Python - Library

Environment

Python 2.7.5

• Assignee: Nobuaki Sukegawa
• Reporter: Benoit Sigoure
• Created: 11/Jan/17 05:01
• Updated: 14/Dec/17 13:55
• Resolved: 28/Oct/17 13:06

Description

As a result of a change made in THRIFT-3917, TSSLSocket now fails with a TypeError in open():

  File "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py", line 293, in open
    self._validate_callback(self.peercert, self._server_hostname)
TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)

Indeed, legacy_validate_callback() takes an extra self argument, which cannot possibly be compatible with the signature of ssl.match_hostname() (which was added in Python 3.2).

Issue Links

• links to: GitHub Pull Request #1166