Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4026

TSSLSocket doesn't work with Python < 2.7.9

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.11.0
    • Component/s: Python - Library
    • Labels:
      None
    • Environment:

      Python 2.7.5

      Description

      As a result of a change made in THRIFT-3917, TSSLSocket now fails with a TypeError in open():

        File "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py", line 293, in open
          self._validate_callback(self.peercert, self._server_hostname)
      TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)
      

      Indeed, legacy_validate_callback() takes an extra self argument, which cannot possibly be compatible with the signature of ssl.match_hostname() (which was added in Python 3.2).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nsuke Nobuaki Sukegawa
                Reporter:
                tsuna Benoit Sigoure
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: