Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4024

Skip() should throw on unknown data types

    XMLWordPrintableJSON

    Details

      Description

      I'm using TBinaryProtocol and a simple transport that reads from a given byte array.

      C# library contains the following code in TProtocolUtil.Skip(TProtocol prot, TType type):

      case TType.List:
      	TList list = prot.ReadListBegin();
      	for (int i = 0; i < list.Count; i++) {
      		Skip(prot, list.ElementType);
      	}
      	prot.ReadListEnd();
      	break;
      

      The type of elements is detected in ReadListBegin(), and, as Skip() does nothing for unknown types, the position in the binary remains the same until the for loop completes.

      So, when you try to deserialize invalid data, and a field type happens to be detected as TType.List, you may end up waiting for a random period of time until deserialization is completed (734707176 iterations of skipping in my case).

      I suggest throwing an exception immediately when list elements type is unknown. May be, it would be good to have a setting like FailOnUnknownType, so that Skip() will throw instead of ignoring.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                Aurora12 Michael Antipin
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m