[THRIFT-4002] Thrift exceptions are not hashable in Python 3

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Python - Compiler
• Labels: compiler python
• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Jelle Zijlstra
• Created: 13/Dec/16 07:40
• Updated: 11/Feb/21 22:26
• Resolved: 12/Dec/19 13:51

Description

The Thrift-to-Python compiler generates `_eq` but not `hash_` for Thrift exception classes, which makes them not hashable in Python 3. Due to http://bugs.python.org/issue28603, this can lead the Python standard library to throw an error while printing tracebacks involving Thrift exceptions.

The attached patch generates `_hash_` for Thrift exceptions. This can technically be incorrect since Thrift exceptions are mutable (compare https://issues.apache.org/jira/browse/THRIFT-162), but in practice it seems unlikely that people would mutate exception instances other than directly after creating them, and without this patch some Thrift exceptions cannot be displayed by the standard library.

Issue Links

• links to: GitHub Pull Request #1835