[THRIFT-3958] CMake WITH_MT option for windows static runtime linking does not support the cmake build type RelWithDebInfo

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: C++ - Compiler, C++ - Library

Environment

Visual Studio 2010, CMake 3.6

• Assignee: James E. King III
• Reporter: James E. King III
• Created: 03/Nov/16 22:58
• Updated: 12/Dec/16 18:02
• Resolved: 10/Nov/16 21:37

Description

There is code in DefinePlatformSpecifc.cmake (note the file name has a typo in it) that allows one to set -DWITH_MT=ON and that will force the build to use a static runtime link. This works for debug and release builds, but not for RelWithDebInfo builds because the list in the cmake file is incomplete.

It would be nice to switch to the ucm.cmake tools to make this a bit easier, but to fix this just a couple lines need to be added to that define cmake.

Issue Links

• links to: GitHub Pull Request #1123