Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3944

TSSLSocket has dead code in checkHandshake

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.9.3
    • Fix Version/s: 0.11.0
    • Component/s: C++ - Library
    • Labels:
      None

      Description

      There is a block of code in checkHandshake that attempts to set read/write memory bios to be nonblocking. This code doesn't do anything:
      https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L441

      Here's what this code looks like, and the problems:

      As far as I can tell, this block of code does nothing and will not change functionality. If there's a reason that it's there, it needs to be re-implemented.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tewang Ted Wang
                Reporter:
                tewang Ted Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: