[THRIFT-3943] Coverity Scan identified some high severity defects

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: C++ - Library, Lua - Library

Environment

https://scan.coverity.com/projects/thrift

• Assignee: James E. King III
• Reporter: James E. King III
• Created: 05/Oct/16 18:46
• Updated: 14/Oct/16 02:16
• Resolved: 13/Oct/16 21:00

Description

Coverity Scan identified 9 issues of high severity.
I dismissed 4 of them as false positives; coverity lost track of the handling of socket file descriptors across multiple layers of calls; this left 5 issues, and I took care of a number of insignificant issues as well:

1295822 - memory leak in ThreadFactoryTests
1216842 - uninitialized rfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W)
1216841 - uninitialized wfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W)
1216840 - getsockname is always passed uninitialized addrlen
1295810 - uninitialized variables in test
1295808 - uninitialized variable in test
1295804 - structurally dead code in processor test event log - changed to use environment variable
excuded:
1174563 - memory leak in compiler class handling functions
1174671 - uninitialized variable in FunctionRunner (intervalMs_)
1174669, 1174763, 1295806, 1295807, 1295809 - uninitialized variable in TSocket (peerPort_)

Issue Links

• relates to: THRIFT-2564 misc. Lua issues reported by coverity scan
• links to: GitHub Pull Request #1109