Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3936

Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, uint32_t)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.10.0
    • Component/s: C++ - Library
    • Labels:
      None
    • Environment:

      Visual Studio 2013, VS2013, Visual Studio 2010, VS2010, Windows

      Description

      A change introduced in July changed some code that won't compile on VS2013:

      https://github.com/apache/thrift/commit/e5176241c325837967a07d6d20e0e9a789fbd107

      snprintf is not available.

      A pull request was submitted for this by someone in the community (thank you!):

      https://github.com/apache/thrift/pull/1096

      I recommended that the fix be done using PlatformSocket.h for abstraction of the platform; I offered to submit a PR to do this.

      In addition I found that with VS2010 I could not compile anything using TApplicationException.h because uint32_t is used within it, but it doesn't include stdlib.h.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jking3 James E. King III
                Reporter:
                jking3 James E. King III
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0.25h Original Estimate - 0.25h
                  0.25h
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h