[THRIFT-391] Memory leak in fastbinary

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.1
• Component/s: Python - Library

Environment

Linux 2.6.21 (Debian)

• Patch Info: Patch Available
• Assignee: Alexander Shigin
• Reporter: Garrett Smith
• Created: 21/Mar/09 20:47
• Updated: 24/Mar/09 01:41
• Resolved: 24/Mar/09 01:41

Description

When a struct has a map member, fastbinary.binary_encode leaks memory.

Use testmem.tar.gz app to recreate the problem.

# tar xzf testmem.tar.gz
# cd testmem
# ./testmem fast

As this is running, use top or pidstat to view the memory consumed by the process. Hit CTRL-C to stop. On my system it steadily increases.

To compare the results using the 'default' encoding technique (using pure Python TBinaryProtocol), run testmem as follows:

# ./testmem default

Note (again, using top, pidstat, etc.) that the memory used is constant.

It appears that the 'map' member triggers this. E.g. string, int members do not cause the leak.