Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3885

PHP: Error when readI64 in TCompactProtocol

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • 0.7, 0.8, 0.9, 0.9.1, 0.9.2, 0.9.3
    • 0.10.0
    • PHP - Library

    • all

    • Patch

    Description

      In line 618 of readI64 of TCompactProtocol, the number of shift bit is error. It must be
      $hi |= (($byte & 0x7f) >> (7 - ($shift - 25)));

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-3827 php CompactProtocol readI64 function has bug, when value has 32bit ~64bit, Example：value=1461563457000

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #1052

          Activity

            People

              nsuke Nobuaki Sukegawa
              czm1989 Chen Zhiming
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: