[THRIFT-3885] PHP: Error when readI64 in TCompactProtocol

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.7, 0.8, 0.9, 0.9.1, 0.9.2, 0.9.3
• Fix Version/s: 0.10.0
• Component/s: PHP - Library
• Labels: patch

Environment

all

• Flags: Patch
• Assignee: Nobuaki Sukegawa
• Reporter: Chen Zhiming
• Created: 21/Jul/16 03:14
• Updated: 28/Sep/16 13:28
• Resolved: 20/Aug/16 09:45

Description

In line 618 of readI64 of TCompactProtocol, the number of shift bit is error. It must be
$hi |= (($byte & 0x7f) >> (7 - ($shift - 25)));

Issue Links

• duplicates: THRIFT-3827 php CompactProtocol readI64 function has bug, when value has 32bit ~64bit, Example：value=1461563457000
• links to: GitHub Pull Request #1052