[THRIFT-3860] Elephant-bird application Test fails for Thrift

• Type: Question
• Status: Closed
• Priority: Minor
• Resolution: Information Provided
• Affects Version/s: 0.7
• Fix Version/s: 0.10.0
• Component/s: Java - Compiler

Environment

Have installed thrift 0.7

• Assignee: James E. King III
• Reporter: sonali shrivastava
• Created: 22/Jun/16 10:28
• Updated: 12/Aug/16 01:29
• Resolved: 22/Jun/16 19:26

Description

Hello Thrift Team,

I am trying to port Elephant Bird Stable Release "2.2.3" on RHEL 7.2 ppc64le using open jdk 1.8

Got success in running ant, ant compile, ant resolve, ant jar and for other targets too except got failure for ant test.

It gives me Test Failure for "thrift" in below line:
[junit] Running com.twitter.elephantbird.pig.piggybank.TestThriftToPig
[junit] Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.081 sec
[junit] TEST com.twitter.elephantbird.pig.piggybank.TestThriftToPig FAILED

By debugging failures,
I see, it is failing on line no. 160 i.e.
assertEquals("{(1,0,34,27000,16777216,6000000000,3.141592653589793,JSON THIS! \"^A," + ooe.zomg_unicode +
",0,base64,

{(1),(2),(3)},{(1),(2),(3)}

,

{(1),(2),(3)}),(1,0,35,27000,16777216,6000000000,3.141592653589793,JSON THIS! \"^A," +
ooe.zomg_unicode + ",0,base64,{(1),(2),(3)}

,

{(1),(2),(3)},{(1),(2),(3)}

)}-{({}),(

{(and a one),(and a two)}),({(then a one, two),(three!),(FOUR!!)})}-{zero={}, three={}, two={(1,Wait.),(2,What?)}}",
(toTuple(type, hm).toDelimitedString("-")));

For debugging purpose, i have added logs and could get below clarity for string comparison failing as a result they are not equal and so assert error, following are details log i printed:
FAILED
expected:<...,{(1),(2),(3)})}-{({[}),({(and a one),(and a two)}

),(

{(then a one, two),(three!),(FOUR!!)})}-{zero={}, three={}, two={(1,Wait.),(2,What?)]}}>
but was:<...,{(1),(2),(3)})}-{({[(and a one),(and a two)}),({}),({(then a one, two),(three!),(FOUR!!)}

)}-{zero={}, two=

{(1,Wait.),(2,What?)}

, three={]}}>
junit.framework.AssertionFailedError.

If I comment above line, this happens similar to line below too:
assertEquals("(bob,jenkins),42,[e-mail],

{(415-555-5555,HOME)}

", toTuple(type, person).toDelimitedString(","));

as well as also for line i.e.
assertTrue( // the order of elements in map could vary because of HashMap
tupleString.equals("(bob,jenkins)-

{MOBILE=650-555-5555, WORK=415-555-5555, HOME=408-555-5555}

") ||
tupleString.equals("(bob,jenkins)-

{MOBILE=650-555-5555, HOME=408-555-5555, WORK=415-555-5555}

"));

When i comment all 3 lines above, test passes for all other modules of it and also for other projects of elephant-bird.

Have build application for "RHEL 7.1 x86-64" too, got same mentioned error.
It seems this is coding issue.

@Thrift Team:
As it is thrift test failure in application "elephant-bird", It will be good if you please mention me for the reason it is failing for com.twitter.elephantbird.pig.piggybank.TestThriftToPig?

Thanks & Regards,
Sonali Shrivastava