Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3837

Thift 0.9.3 can't be build with QuickCheck 2.8.2 and unordered-containers 0.2.6

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 0.9.3
    • Fix Version/s: 0.10.0
    • Component/s: Haskell - Library
    • Labels:

      Description

      QuickCheck 2.8.2 provide Arbitrary instance for Map and Set from containers already, this change result in failure of building thrift with:

      ```
      src/Thrift/Arbitraries.hs:29:10:
      Duplicate instance declarations:
      instance (Ord k, Arbitrary k, Arbitrary v) => Arbitrary (Map k v)
      – Defined at src/Thrift/Arbitraries.hs:29:10
      instance [safe] (Ord k, Arbitrary k, Arbitrary v) =>
      Arbitrary (Map k v)
      – Defined in ‘Test.QuickCheck.Arbitrary’

      src/Thrift/Arbitraries.hs:32:10:
      Duplicate instance declarations:
      instance (Ord k, Arbitrary k) => Arbitrary (Set.Set k)
      – Defined at src/Thrift/Arbitraries.hs:32:10
      instance [safe] (Ord a, Arbitrary a) => Arbitrary (Set.Set a)
      – Defined in ‘Test.QuickCheck.Arbitrary’
      ```
      Same thing happened for unordered-containers package where Hashable instance are defined from 0.2.6 version.

      A version constraint <2.8.2 on QuickCheck and <0.2.6 on unordered-containers should be added to thrift's cabal, this can be done using hackage's revision(editing cabal file without upload a new tarball), maintainer please do this!

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                nsuke Nobuaki Sukegawa
                Reporter:
                winterland winterland
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: