Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3786

Node.js TLS emits 'connect' before connection is ready

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • Node.js - Library
    • None
    • Patch Available

    Description

      When using a TLS connection, the Node.js Thrift connection instance will emit a `connect` event early, making it possible to lose commands.

      `connect` is emitted by the Thrift connection instance when the underlying socket is opened, instead of when the TLS handshake has completed. Making matters worse, the offline queue is flushed during this premature `connect`, which means that any commands issued prior to the TLS connection handshake will be lost.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-3156 Node TLS: server executes processing logic two full times

          • Major - Major loss of function.
          • Closed

          Activity

            People

              codesf Randy Abernethy
              jamesreggio James Reggio
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: