Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3786

Node.js TLS emits 'connect' before connection is ready

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Node.js - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      When using a TLS connection, the Node.js Thrift connection instance will emit a `connect` event early, making it possible to lose commands.

      `connect` is emitted by the Thrift connection instance when the underlying socket is opened, instead of when the TLS handshake has completed. Making matters worse, the offline queue is flushed during this premature `connect`, which means that any commands issued prior to the TLS connection handshake will be lost.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                codesf Randy Abernethy
                Reporter:
                jamesreggio James Reggio
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: