[THRIFT-3753] TServerFramework::stop may fail to interrupt connected clients

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Ted Wang
• Reporter: Ted Wang
• Created: 23/Mar/16 19:52
• Updated: 12/Aug/16 01:29
• Resolved: 16/Jun/16 20:12

Description

This is a sequence that exposes the race condition:
(1) Thread-1: in serve(), blocked on accept()
(2) Thread-2: in stop(), calls interrupt()
(3) Thread-2: in stop(), in interruptChildren(), checked that socket is valid
(4) Thread-1: in serve(), unblocked because of interrupt(), calls releaseOneDescriptor
(5) Thread-2: in interruptChildren(), send fails so clients are not interrupted

Issue Links

• links to: GitHub Pull Request #959