[THRIFT-3732] performance optimization

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: PHP - Library
• Assignee: Unassigned
• Reporter: jiang dongliang
• Created: 10/Mar/16 02:58
• Updated: 10/Mar/16 04:12

Description

It's not necessary to get the instance inside the while loop.
When transport a big data, the function calls up to 17,681 times.
After the optimization, it's possible reducing to 125 times.
For example file TTransport.php

public function readAll($len)
{
// return $this->read($len);

$data = '';
$got = 0;
/** original
while (($got = TStringFuncFactory::create()->strlen($data)) < $len)

{ $data .= $this->read($len - $got); }
*/
$factory = TStringFuncFactory::create();
while (($got = $factory->strlen($data)) < $len) { $data .= $this->read($len - $got); }

return $data;
}