Details
-
Bug
-
Status: Closed
-
Blocker
-
Resolution: Fixed
-
None
-
None
-
Patch Available
Description
Files that try to load thrift_native need to rescue from LoadError. LoadError isn't a StandardError, so isn't caught by a bare rescue.
From current HEAD (757825).
Clio:rb kev$ g g thrift_native
Manifest:ext/thrift_native.c
ext/extconf.rb:create_makefile 'thrift_native'
ext/thrift_native.c:void Init_thrift_native() {
lib/thrift/protocol/binaryprotocolaccelerated.rb:require 'thrift_native'
spec/protocol_spec.rb:require "thrift_native"
spec/spec_helper.rb:require "thrift_native"
We may want to put the require for the extension in a ruby file, and just rescue there. That way load path stuff is taken care of properly, and we get our rescue.
How's this? I cleaned up some missed dead code related to deprecation, as well.