Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3715

Test that protocol failure when thrift_transport_read_all performs only one read

    XMLWordPrintableJSON

Details

    • Test
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 0.10.0
    • None
    • C glib - Library
    • None

    Description

      In THRIFT-3569 tests called ReadAndWriteManyFrames were added in the binary and compact protocol test suites to check that the protocols failed on larger reads (before thrift_transport_read_all was implemented and applied). These tests were shown to (erroneously) succeed when thrift_transport_read_all is replaced with a single read (instead of a loop). Perhaps the best solution is to create a fake transport with a fixed (e.g.) single-byte read for testing.

      Attachments

        Activity

          People

            cjmay Chandler May
            cjmay Chandler May
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: