[THRIFT-370] unset fields in structs in c++ have __isset set to true

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.1
• Fix Version/s: 0.1
• Component/s: C++ - Library

Environment

Linux 2.6.27-11 x86_64

• Assignee: Unassigned
• Reporter: Nick Lanham
• Created: 13/Mar/09 22:08
• Updated: 14/Mar/09 07:42
• Resolved: 14/Mar/09 05:14

Description

If you have a struct like:

struct test_struct {
1:string test_string
}

and then in a c++ client you do:

test_struct foo;
client.someFunc(foo)

then the server will see it's argument (arg) as having arg.__isset.test_string set to true.

similarly from the client side if expect a return value and do:

test_struct returnVal;
client.someFunc(returnVal);

and the server does not set the returnVal to anything it will still see returnVal.__isset.test_string as true

in all cases the string is set to the empty string as the constuctor for test_struct sets it, but __isset should not be true.

Attached (should be) a simple test case. Just untar run "thrift --gen cpp isset.thrift" and then run make. start up the server and run the client to see the output.