[THRIFT-3703] Unions Field Count Does Not Consider Map/Set/List Fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3, 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Go - Compiler
• Labels: golang thrift union

Environment

Ubuntu 15.10

• Assignee: Duru Can Celasun
• Reporter: Tom Deering
• Created: 01/Mar/16 21:29
• Updated: 14/Dec/17 13:55
• Resolved: 31/May/17 20:59

Description

Go code for unions generated by Thrift 0.9.3 fails to consider map/set/list fields of a union when enforcing that the number of fields set is 1. For example:

union Foo{
    1: map<bool,bool> u1
    2: set<bool> u2,
    3: list<bool> u3,
    4: bool u4,
}

Produces Go code:

type Foo struct {
	U1 map[bool]bool `thrift:"u1,1" json:"u1,omitempty"`
	U2 map[bool]bool `thrift:"u2,2" json:"u2,omitempty"`
	U3 []bool        `thrift:"u3,3" json:"u3,omitempty"`
	U4 *bool         `thrift:"u4,4" json:"u4,omitempty"`
}
...
func (p *Foo) CountSetFieldsFoo() int {
	count := 0
	if p.IsSetU4() {
		count++
	}
	return count
}
...
func (p *Foo) Write(oprot thrift.TProtocol) error {
	if c := p.CountSetFieldsFoo(); c != 1 {
		return fmt.Errorf("%T write union: exactly one field must be set (%d set).", p, c)
	}
...

Due to this bug, Thrift will complain that a union with only the fields u1, u2, or u3 set has no fields set. And it will allow all four fields to be set.

Issue Links

• links to: GitHub Pull Request #1281