Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3657

D TFileWriterTransport close should use non-priority send

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 0.11.0
    • D - Library
    • None

    Description

      prioritySend is used in TFileWriterTransport close method.
      A possible problem with this is that even synchronized calls that are strictly before close call can be ignored in rare occasions.

      The author has put a comment "FIXME: Should use normal send here" and there's no reason not to.
      I suspect it is a remnant of old implementation or local debug stuff.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nsuke Nobuaki Sukegawa
            nsuke Nobuaki Sukegawa
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment