Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3657

D TFileWriterTransport close should use non-priority send

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: D - Library
    • Labels:
      None

      Description

      prioritySend is used in TFileWriterTransport close method.
      A possible problem with this is that even synchronized calls that are strictly before close call can be ignored in rare occasions.

      The author has put a comment "FIXME: Should use normal send here" and there's no reason not to.
      I suspect it is a remnant of old implementation or local debug stuff.

        Attachments

          Activity

            People

            • Assignee:
              nsuke Nobuaki Sukegawa
              Reporter:
              nsuke Nobuaki Sukegawa
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: