Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3596

Better conformance to PEP8

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.10.0
    • Python - Library

    Description

      py coding_standards.md states it follows PEP8 but currently it does not do so at all.
      So a typical experience of a first-time (potential) py contributor would be to see red warnings all over the display and then has to either adjust their editor's settings or stop there.

      On the other hand, a huge downside of global reformat is git-blame experience but will be mostly mitigated by git blame -w in this case.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-2954 calling function with parameter type different as defined in idl breaks the connection

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. THRIFT-3601 Better conformance to PEP8 for generated code

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              nsuke Nobuaki Sukegawa
              nsuke Nobuaki Sukegawa
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: