[THRIFT-357] Buffer and Connection bloat in TNonBlockingServer

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: C++ - Library
• Patch Info: Patch Available
• Assignee: Anthony Giardullo
• Reporter: Anthony Giardullo
• Created: 04/Mar/09 23:35
• Updated: 19/Mar/09 03:55
• Resolved: 19/Mar/09 03:55

Description

This patch helps to reduce the amount of memory allocated by TNonBlockingServer. It uses a configurable limit on the number of idle connections to keep around, and has a configurable limit on the amount of memory to keep allocated in the readBuffer when the connection is closed. This fix is in use at Facebook and has significantly reduced the amount of memory used by Scribe (https://sourceforge.net/projects/scribeserver/).

See THRIFT-265 for another memory usage fix which reallocates input/output buffers every 512 reads/writes. THRIFT-265(and THRIFT-354) and this patch can be used together to tune the amount of memory used. The buffer_limit patch is especially useful for the case when there are many idle TConnections with large buffers allocated.

Issue Links

• is related to: THRIFT-354 Tunable reset buffer behavior in TNonblockingServer

Sub-Tasks

• Fix type on accessors to connectionStackLimit_: Closed