[THRIFT-3546] NodeJS code should not be namespaced (and is currently not strict-mode compliant)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: Node.js - Compiler
• Assignee: Benjamin Gould
• Reporter: Yunchi Luo
• Created: 13/Jan/16 05:04
• Updated: 12/Oct/16 16:19
• Resolved: 12/Oct/16 16:19

Description

Code generated for NodeJS, whether with a js namespace specified or not, seems to fail strict mode. Specifically, it doesn't always generate "var" when needed. This might not sound like a big issue but it's quite a pain to deal with...

It is standard nowadays to enable strict mode for Javascript code (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode). And babel, which is one of most popular ES6 => ES5 transpilers, while does not force strict mode, does seem to break when you don't use "var".

I think the best solution here is really to just stop using namespaces in node code. Every type will be declared with "var", and if exported, also assigned to "module.exports".

I don't believe namespaces currently generated in the node code is directly used anywhere or is even accessible outside the file?

Issue Links

• is related to: THRIFT-3835 Thrift generates javascript code for node js with error
• relates to: THRIFT-3410 Support for 'use strict' in generated javascript code
• links to: GitHub Pull Request #1111