Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3536

Error 'char' does not contain a definition for 'IsLowSurrogate' for WP7 target

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • C# - Library
    • None
    • Windows Phone 7

    • Patch Available

    Description

      THRIFT-3403 added calls to IsLow/HighSurrogate() which is not supported on Windows Phone 7, at least Windows Phone 8 is required.

      However, as Windows Phone 7 is an outdated platform, I am going to remove the WP7 target from trunk entirely. Thrift 0.9.3 is not affected, so if anyone needs WP7 support, please use Thrift 0.9.3.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user Jens-G opened a pull request:

            https://github.com/apache/thrift/pull/781

            THRIFT-3536 Error 'char' does not contain 'IsLowSurrogate'

            THRIFT-3536 Error 'char' does not contain a definition for 'IsLowSurrogate' for WP7 target
            Client: C#
            Patch: Jens Geyer

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/Jens-G/thrift THRIFT-3536

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/thrift/pull/781.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #781


            commit 620d3cecea0bdc35f6f36a4cbbeccd51b9bce874
            Author: Jens Geyer <jensg@apache.org>
            Date: 2016-01-10T12:33:57Z

            THRIFT-3536 Error 'char' does not contain a definition for 'IsLowSurrogate' for WP7 target
            Client: C#
            Patch: Jens Geyer


            githubbot ASF GitHub Bot added a comment - GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/781 THRIFT-3536 Error 'char' does not contain 'IsLowSurrogate' THRIFT-3536 Error 'char' does not contain a definition for 'IsLowSurrogate' for WP7 target Client: C# Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-3536 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/781.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #781 commit 620d3cecea0bdc35f6f36a4cbbeccd51b9bce874 Author: Jens Geyer <jensg@apache.org> Date: 2016-01-10T12:33:57Z THRIFT-3536 Error 'char' does not contain a definition for 'IsLowSurrogate' for WP7 target Client: C# Patch: Jens Geyer
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/thrift/pull/781

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/781
            jensg Jens Geyer added a comment -

            Committed.

            jensg Jens Geyer added a comment - Committed.

            People

              jensg Jens Geyer
              jensg Jens Geyer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: