[THRIFT-3521] TSimpleJSONProtocolTest is not deterministic (fails when run on JDK 8)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Java - Library

Environment

OpenJDK 8

• Assignee: Benjamin Gould
• Reporter: Benjamin Gould
• Created: 05/Jan/16 17:13
• Updated: 19/Feb/16 02:17
• Resolved: 06/Jan/16 02:56

Description

TSimpleJSONProtocolTest has a couple of tests where structs are serialized, and the resultant JSON string is compared for equality with an expected value.

Some of the structs' fields are sets, which do not ensure consistent ordering, causing this test to fail in environments where the "natural" ordering of the elements in the HashSet do not match the expected value.

Suggested fix is to unset the fields that cause the inconsistent ordering and remove them from the expected value.