[THRIFT-3512] c_glib: Build fails due to missing features.h

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.10.0
• Component/s: C glib - Library
• Labels: c_glib library test-suite

Environment

gcc 4.8.5 on Haiku hrev49940 (x86)

• Assignee: Simon South
• Reporter: Simon South
• Created: 29/Dec/15 16:40
• Updated: 06/Jan/16 02:06
• Resolved: 02/Jan/16 18:13

Description

Building the C (GLib) library test suite on Haiku fails with an error about a missing features.h:

testbinaryprotocol.c:25:22: fatal error: features.h: No such file or directory
 #include <features.h>
                      ^

This header appears to be part of GNU libc and is not defined by POSIX, which explains why it would not be available on Haiku. The same applies to the BSDs, for which I notice a preprocessor directive was added that explicitly checks for these platforms.

A better solution is probably to omit including the header whenever GNU libc is not being used, rather than listing every platform on which it is not available.