[THRIFT-3498] C++ library assumes optional function pthread_attr_setschedpolicy is available

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.10.0
• Component/s: C++ - Library
• Labels: c++ haiku library posix

Environment

gcc 4.8.5 on Haiku hrev49934 (x86)

• Assignee: Simon South
• Reporter: Simon South
• Created: 21/Dec/15 18:44
• Updated: 06/Jan/16 02:06
• Resolved: 02/Jan/16 18:13

Description

Building on Haiku the latest code from git fails with

src/thrift/concurrency/PosixThreadFactory.cpp: In member function 'virtual void apache::thrift::concurrency::PthreadThread::start()':
src/thrift/concurrency/PosixThreadFactory.cpp:127:58: error: 'pthread_attr_setschedpolicy' was not declared in this scope
     if (pthread_attr_setschedpolicy(&thread_attr, policy_) != 0) {

This is because pthread_attr_setschedpolicy is in fact an optional function POSIX implementations are not required to provide—and Haiku's POSIX-compatibility layer does not.

Thrift should be checking for the availability of this function before including it in the source code. (Nothing else seems to rely on the thread-scheduling policy being available, so it's just a matter of omitting this one function call.)