[THRIFT-3486] Java generated `getFieldValue` is incompatible with `setFieldValue` for binary values.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Java - Compiler
• Assignee: Benjamin Gould
• Reporter: Gospo
• Created: 11/Dec/15 15:49
• Updated: 06/Jan/16 02:06
• Resolved: 02/Jan/16 18:13

Description

Problem description

In case of a binary field, getFieldValue returns a byte[] while setFieldValue expects a ByteBuffer.

This design yields an unexpected requirement and is error prone.

This is a perfectly fine use-case that a client wants to write a field value from one object to another object of the same thrift generated class:

obj1.setFieldValue(SOME_FIELD, obj2.getFieldValue(SOME_FIELD))

It is a reasonable assumption that if I use a getter to obtain some property value, the corresponding setter should accept a value of the same type.

Currently if SOME_FIELD is a binary type field an exception is thrown: java.lang.ClassCastException: [B cannot be cast to java.nio.ByteBuffer.

Change proposal

Setter setFieldValue should accept a byte[] value for a binary field.