[THRIFT-3466] Set Parameters Have Wrong Key Type in Go Code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: Go - Compiler
• Labels: golang

Environment

Go 1.4.2
Thrift 0.9.3
Ubuntu Linux 14.04
amd64

• Assignee: Unassigned
• Reporter: Tom Deering
• Created: 02/Dec/15 15:13
• Updated: 30/May/17 11:38
• Resolved: 30/May/17 11:38

Description

When Thrift 0.9.3 generates Go code for a service with a parameter that is of type set<typedeffed thing>, the generated Go code parameter is of type map[untypedeffed thing]bool. For example:

Thrift

namespace go bug
typedef string Foo
service FooService{
	void bar (1:set<Foo> foos)
}

Go

func (p *FooServiceClient) Bar(foos map[string]bool) (err error) 

The key type of the Go map should be Foo, not string.