[THRIFT-3422] Go TServerSocket doesn't close on Interrupt

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.10.0
• Component/s: Go - Library
• Assignee: Mark Sonnabaum
• Reporter: Mark Sonnabaum
• Created: 13/Nov/15 16:52
• Updated: 18/Mar/16 18:02
• Resolved: 18/Mar/16 18:02

Description

When using the Go version of TSimpleServer with a TServerSocket, I expected that calling Stop() would close the socket, but it does not. I discovered this in my test suite when I had to assign new port numbers to each test because otherwise they would fail to rebind.

TSimpleServer.Stop calls TServerSocket.Interrupt, which is where I believe the issue lies. The java version's interrupt method calls close, so this seems to be the expected behavior.