Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-3416

Retire old "xxx_namespace" declarations from the IDL

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: Compiler (General)
    • Labels:
      None

      Description

      While poking into the IDL syntax, I found that hidden gem:

      | tok_xsd_namespace tok_literal
          {
            pwarning(1, "'xsd_namespace' is deprecated. Use 'namespace xsd' instead");
            pdebug("Header -> tok_xsd_namespace tok_literal");
            declare_valid_program_doctext();
            if (g_parse_mode == PROGRAM) {
              g_program->set_namespace("cocoa", $2);   // what ... COCOA ?!?
            }
          }
      

      While thinking whether I should do sth about it, I came to the conclusion that the time ist right to "Get rid of this" since today probably really "everyone is using the new hotness", as the comments say.

      Opinions?

      If there are no objections, I'll provide a patch to convert the warnings into an error and remove the rest of it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jensg Jens Geyer
                Reporter:
                jensg Jens Geyer
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: