[THRIFT-3416] Retire old "xxx_namespace" declarations from the IDL

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Compiler (General)
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 11/Nov/15 20:42
• Updated: 18/Mar/16 17:54
• Resolved: 18/Mar/16 17:54

Description

While poking into the IDL syntax, I found that hidden gem:

| tok_xsd_namespace tok_literal
    {
      pwarning(1, "'xsd_namespace' is deprecated. Use 'namespace xsd' instead");
      pdebug("Header -> tok_xsd_namespace tok_literal");
      declare_valid_program_doctext();
      if (g_parse_mode == PROGRAM) {
        g_program->set_namespace("cocoa", $2);   // what ... COCOA ?!?
      }
    }

While thinking whether I should do sth about it, I came to the conclusion that the time ist right to "Get rid of this" since today probably really "everyone is using the new hotness", as the comments say.

Opinions?

If there are no objections, I'll provide a patch to convert the warnings into an error and remove the rest of it.

Issue Links

• breaks: THRIFT-3489 warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]